I thought pink was generally used for breast cancer awareness while rainbow colors represented the LGBT rights movement. ...oh wait, that's why he was zapped. Got it.
You're right, but that's the first reason I thought of as to why Shining Armor would buy a shirt so pink that Twilight subconsciously zaps him on sight.