That's a pretty general question so here's a general answer: Work on a solid knowledge base of anatomy before trying to really do shading, making a strong sketch with shapes that make sense helps a lot when painting. Try to do some mechanical studies as well as some copies of styles you like to get a feel for how other people do things (and for what you enjoy doing!) Process pictures are great for that.
Thank you I'll do that